Skip to content

fix(migrations): incorrect filtering in inject migration#62913

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:62866/inject-migration-file-filtering
Closed

fix(migrations): incorrect filtering in inject migration#62913
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:62866/inject-migration-file-filtering

Conversation

@crisbeto
Copy link
Copy Markdown
Member

The inject migration wasn't implementing file filtering properly which resulted in it passing an invalid tsconfig path to TypeScript.

Fixes #62866.

The inject migration wasn't implementing file filtering properly which resulted in it passing an invalid tsconfig path to TypeScript.

Fixes angular#62866.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 31, 2025
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Jul 31, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 31, 2025
@crisbeto crisbeto requested a review from JoostK July 31, 2025 07:52
Copy link
Copy Markdown
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this makes a lot more sense!

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 31, 2025
@thePunderWoman
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit b1514d5.

The changes were merged into the following branches: main, 20.1.x

thePunderWoman pushed a commit that referenced this pull request Jul 31, 2025
The inject migration wasn't implementing file filtering properly which resulted in it passing an invalid tsconfig path to TypeScript.

Fixes #62866.

PR Close #62913
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inject migration fails to migrate file at given path

3 participants