fix(compiler): exclude more safe reads expression from 2way-binding#62852
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler): exclude more safe reads expression from 2way-binding#62852JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
3b62a2c to
10b10db
Compare
Member
Author
|
This change will require a G3 cleanup, it raised valid errors. |
JoostK
reviewed
Jul 28, 2025
Member
JoostK
left a comment
There was a problem hiding this comment.
Let's have tests for these:
(foo?.bar).baz // not null-safe and would crash at runtime, but may not report an error without `strictNullChecks`
(foo?.bar ?? bar).baz // This is safe and should be allowed10b10db to
38fb1a9
Compare
Member
Author
|
@JoostK, good point. Your 1st example will won't throw with the implementation currently in PR. Will look to support it. |
Priori to this fix the parser would allow safereads in accestor receievers (but the direct one). fixes angular#62837
38fb1a9 to
75929cf
Compare
Member
Author
JoostK
approved these changes
Jul 29, 2025
thePunderWoman
pushed a commit
that referenced
this pull request
Jul 29, 2025
Contributor
|
This PR was merged into the repository by commit 5b25d93. The changes were merged into the following branches: main, 20.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priori to this fix the parser would allow safereads in accestor receievers (but the direct one).
fixes #62837