Skip to content

fix(core): Fixed inject migration schematics for migrate destructured properties#62832

Closed
aparzi wants to merge 1 commit intoangular:mainfrom
aparzi:fix-issue-62626
Closed

fix(core): Fixed inject migration schematics for migrate destructured properties#62832
aparzi wants to merge 1 commit intoangular:mainfrom
aparzi:fix-issue-62626

Conversation

@aparzi
Copy link
Copy Markdown
Contributor

@aparzi aparzi commented Jul 26, 2025

Fixed inject migration schematics for migrate destructured properties

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #62626

What is the new behavior?

Fixed inject migration schematics for migrate destructured properties

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from atscott July 26, 2025 10:06
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jul 26, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 26, 2025
@aparzi aparzi force-pushed the fix-issue-62626 branch 2 times, most recently from d978f3c to ff3fcf4 Compare July 26, 2025 14:37
@aparzi
Copy link
Copy Markdown
Contributor Author

aparzi commented Jul 26, 2025

Fixed lint

@AndrewKushnir AndrewKushnir requested review from crisbeto and removed request for atscott August 12, 2025 13:26
JeanMeche
JeanMeche reviewed Aug 20, 2025
View reviewed changes
@aparzi aparzi requested a review from JeanMeche August 22, 2025 09:20
@JeanMeche
Copy link
Copy Markdown
Member

JeanMeche commented Aug 22, 2025

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 22, 2025
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in the inject migration schematic to correctly handle destructured properties in constructor parameters. The implementation introduces a ParameterMigrationContext to group related parameters, refactors the main migration function to handle different parameter kinds, and adds logic to correctly transform destructured properties into class properties with inject(). A new test case is also added to cover this scenario. The changes are well-structured and the fix appears correct. I have one minor suggestion to improve code clarity.

JeanMeche
JeanMeche reviewed Aug 22, 2025
View reviewed changes
JeanMeche
JeanMeche reviewed Aug 22, 2025
View reviewed changes
@aparzi aparzi requested a review from JeanMeche August 22, 2025 12:29
@aparzi
Copy link
Copy Markdown
Contributor Author

aparzi commented Aug 22, 2025

@JeanMeche fixed lint and made the requested changes

JeanMeche
JeanMeche reviewed Aug 22, 2025
View reviewed changes
@aparzi aparzi requested a review from JeanMeche August 22, 2025 19:13
@JeanMeche JeanMeche removed the request for review from crisbeto August 29, 2025 21:14
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 29, 2025
@aparzi
fix(core): Fixed inject migration schematics for migrate destructured…
04885c8 
… properties

Fixes angular#62626 - Properties used with the destructor are also managed during migration.
@angular-robot angular-robot bot requested a review from JeanMeche August 31, 2025 22:43
@mmalerba
Copy link
Copy Markdown
Contributor

mmalerba commented Sep 2, 2025

This PR was merged into the repository. The changes were merged into the following branches:

mmalerba pushed a commit that referenced this pull request Sep 2, 2025
@aparzi @mmalerba
fix(core): Fixed inject migration schematics for migrate destructured…
dc64f3e 
… properties (#62832)

Fixes #62626 - Properties used with the destructor are also managed during migration.

PR Close #62832
@mmalerba mmalerba closed this in 06f4fd4 Sep 2, 2025
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Oct 3, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@aparzi @JeanMeche @mmalerba