feat(service-worker): Adds for type in provideServiceWorker#62831
Closed
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
Closed
feat(service-worker): Adds for type in provideServiceWorker#62831SkyZeroZx wants to merge 1 commit intoangular:mainfrom
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
Conversation
Enables specifying the script type ('classic' or 'module') when registering Service Workers, improving compatibility with ES module features.
2ec391b to
3b82c3e
Compare
thePunderWoman
approved these changes
Aug 6, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
LGTM! Thanks!
reviewed-for: fw-general, public-api
Member
|
This PR was merged into the repository by commit 5220b51. The changes were merged into the following branches: main |
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(service-worker): Add type option to provideServiceWorker
Enables specifying the script type ('classic' or 'module') when registering Service Workers, improving compatibility with ES module features.
The change includes:
typetoSwRegistrationOptionsinterfacetypeoptionMotivation/Use Cases
The
typeoption is particularly useful for:Proposed Solution
typeproperty to theSwRegistrationOptionsabstract classnavigator.serviceWorker.register()APIExamples of New Usage
Basic configuration with provideServiceWorker