fix(router): handle errors from view transition readiness#62535
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
fix(router): handle errors from view transition readiness#62535arturovt wants to merge 1 commit intoangular:mainfrom
arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
This commit adds a `.catch()` handler to `transition.ready` from `document.startViewTransition` to prevent `AbortError`s in Safari when `startViewTransition` is called synchronously multiple times.
atscott
reviewed
Jul 8, 2025
| // complete (below), which includes the update phase of the routed components. | ||
| return createRenderPromise(injector); | ||
| }); | ||
| transition.ready.catch((error) => { |
Contributor
There was a problem hiding this comment.
What happens to the finished promise? Is that resolved or rejected?
Contributor
Author
There was a problem hiding this comment.
Checked both Chrome and Safari. the finished always resolves (never rejects), even if the ready rejects.
atscott
approved these changes
Jul 9, 2025
Contributor
|
This PR was merged into the repository by commit e9f2156. The changes were merged into the following branches: main, 20.1.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 14, 2025
This commit adds a `.catch()` handler to `transition.ready` from `document.startViewTransition` to prevent `AbortError`s in Safari when `startViewTransition` is called synchronously multiple times. PR Close #62535
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a
.catch()handler totransition.readyfromdocument.startViewTransitionto preventAbortErrors in Safari whenstartViewTransitionis called synchronously multiple times.Closes #62491