refactor(core): use quad linked signal nodes for performance#62284
Closed
milomg wants to merge 2 commits intoangular:mainfrom
Closed
refactor(core): use quad linked signal nodes for performance#62284milomg wants to merge 2 commits intoangular:mainfrom
milomg wants to merge 2 commits intoangular:mainfrom
Conversation
641b2fd to
50fe202
Compare
dc613d8 to
d19ace3
Compare
Member
Author
|
Caretaker note: apply patch cl/777701693 TESTED=TGP |
3f9378c to
ab612ff
Compare
iteriani
reviewed
Jul 7, 2025
inspired by the design of Preact's signals, use linked lists instead of arrays for faster signal creation
approve the new symbols that appear from bundling the signals changes
thePunderWoman
approved these changes
Jul 23, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
iteriani
approved these changes
Jul 23, 2025
Contributor
|
reviewed-for: primitives |
Member
Author
|
TESTED=TGP Caretaker note: apply patch cl/777701693 |
Member
|
This PR was merged into the repository by commit 92c2d2a. The changes were merged into the following branches: main, 20.1.x |
crisbeto
pushed a commit
that referenced
this pull request
Jul 28, 2025
inspired by the design of Preact's signals, use linked lists instead of arrays for faster signal creation PR Close #62284
crisbeto
pushed a commit
that referenced
this pull request
Jul 28, 2025
approve the new symbols that appear from bundling the signals changes PR Close #62284
crisbeto
pushed a commit
that referenced
this pull request
Jul 28, 2025
approve the new symbols that appear from bundling the signals changes PR Close #62284
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Switch to using https://preactjs.com/blog/signal-boosting/ for a performance boost in signal initialization
We introduce the idea of a ReactiveLink in addition to a ReactiveNode. Then, instead of storing an array of ReactiveNodes, we store a ReactiveLink'ed List.
By merging the sources and observers into one massive linked list, we avoid having to push and pop from many different arrays, and can instead use linked list operations that are faster.
This PR also avoids duplication of producers in two cases: when reading the same producer twice in a row, and when reading from a live producer
Does this PR introduce a breaking change?
Other information