fix(compiler): produce more accurate errors for interpolations#62258
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler): produce more accurate errors for interpolations#62258crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
commented
Jun 25, 2025
| it('should report parsing errors on the specific interpolated expressions', () => { | ||
| const errors = parse( | ||
| ` | ||
| bunch of text bunch of text bunch of text bunch of text bunch of text bunch of text |
Member
Author
There was a problem hiding this comment.
For reference, the current code will report 3 errors, each of which covers the entire string including the plain text. With the changes the errors are only reported on interpolations.
Currently when there's a parser error in interpolated text, the compiler reports an error on the entire text node. This can be really noisy in long strings. These changes switch to reporting the errors on the specific expressions that caused them.
b333f43 to
497e71e
Compare
AndrewKushnir
approved these changes
Jun 25, 2025
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Thanks for the improvement @crisbeto 👍
Contributor
|
This PR was merged into the repository by commit 089ad0e. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when there's a parser error in interpolated text, the compiler reports an error on the entire text node. This can be really noisy in long strings.
These changes switch to reporting the errors on the specific expressions that caused them.