fix(core): Wrap ErrorEvent with no error property #62081
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
approved these changes
Jun 16, 2025
JoostK
reviewed
Jun 16, 2025
392de4c to
ed8d8bf
Compare
JoostK
approved these changes
Jun 17, 2025
Member
JoostK
left a comment
There was a problem hiding this comment.
A test would be nice to have this accounted for in coverage
ed8d8bf to
b6451b6
Compare
JoostK
reviewed
Jun 17, 2025
| window.onerror = originalWindowOnError; | ||
| }); | ||
|
|
||
| it('installs global error handler once', async () => { |
Member
There was a problem hiding this comment.
"handles error events without error"
This commit updates the global error listener to wrap the global ErrorEvent in a new Error with cause if the error property is undefined. fixes angular#62078
b6451b6 to
bd914c2
Compare
JoostK
approved these changes
Jun 17, 2025
Member
|
This PR was merged into the repository by commit 572c32a. The changes were merged into the following branches: main, 20.0.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jun 18, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the global error listener to wrap the global ErrorEvent in a new Error with cause if the error property is undefined.
fixes #62078