Skip to content

fix(core): takeUntilDestroyed completes immediately if DestroyRef a… #61847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atscott wants to merge 1 commit into from
Closed

fix(core): takeUntilDestroyed completes immediately if DestroyRef a… #61847

atscott wants to merge 1 commit into from

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Jun 3, 2025

…lready destroyed

Adds fix directly for takeUntilDestroyed to unsubscribe when already destroyed instead of putting
synchronous behavior on DestroyRef.onDestroyed callback as in #58008

fixes #54527

@atscott
fix(core): takeUntilDestroyed completes immediately if DestroyRef a…
6ab7d1c 
…lready destroyed

Adds fix directly for `takeUntilDestroyed` to unsubscribe when already
destroyed instead of putting
synchronous behavior on `DestroyRef.onDestroyed` callback as in angular#58008

fixes angular#54527
@atscott atscott added the target: patch This PR is targeted for the next patch release label Jun 3, 2025
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jun 3, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 3, 2025
@atscott atscott added the requires: TGP This PR requires a passing TGP before merging is allowed label Jun 3, 2025
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Jun 3, 2025
@atscott atscott mentioned this pull request Jun 3, 2025
Closed
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jun 4, 2025
@ngbot
Copy link

ngbot bot commented Jun 4, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending status "mergeability" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott atscott added requires: TGP This PR requires a passing TGP before merging is allowed and removed action: merge The PR is ready for merge by the caretaker labels Jun 4, 2025
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Jun 4, 2025
@atscott
Copy link
Contributor Author

atscott commented Jun 4, 2025 •
edited
Loading

TGP

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jun 4, 2025
@kirjs
Copy link
Contributor

kirjs commented Jun 4, 2025

This PR was merged into the repository by commit 2bd3a43.

The changes were merged into the following branches: main, 20.0.x

kirjs pushed a commit that referenced this pull request Jun 4, 2025
@atscott @kirjs
fix(core): takeUntilDestroyed completes immediately if DestroyRef a…
8c60cbf 
…lready destroyed (#61847)

Adds fix directly for `takeUntilDestroyed` to unsubscribe when already
destroyed instead of putting
synchronous behavior on `DestroyRef.onDestroyed` callback as in #58008

fixes #54527

PR Close #61847
@kirjs kirjs closed this in 2bd3a43 Jun 4, 2025
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 5, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

NG0911: View has already been destroyed.

3 participants

@atscott @kirjs @alxhub