fix(compiler): only report parser errors on invalid expression#61793
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler): only report parser errors on invalid expression#61793crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
AndrewKushnir
approved these changes
May 31, 2025
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@crisbeto thanks for the fix!
Currently we reuse the same binding parser for all expressions in the template. Under the hood, the parser has a single `errors` array that it passes into all ASTs which means that if there's one binding with an error, those errors will be propagated to all other ASTs in the template. These changes switch to having a unique `errors` array for each AST so we only report errors once. Relates to angular#61792.
067690c to
10d0bee
Compare
|
LGTM! |
Contributor
|
This PR was merged into the repository by commit 5a76826. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we reuse the same binding parser for all expressions in the template. Under the hood, the parser has a single
errorsarray that it passes into all ASTs which means that if there's one binding with an error, those errors will be propagated to all other ASTs in the template.These changes switch to having a unique
errorsarray for each AST so we only report errors once.Relates to #61792.