fix(core): unregister onDestroy in toSignal.#61514
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): unregister onDestroy in toSignal.#61514JeanMeche wants to merge 1 commit intoangular:mainfrom
onDestroy in toSignal.#61514JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
We cleanup if the observable completes before the onDestroy fires. fixes angular#61511
pkozlowski-opensource
approved these changes
May 20, 2025
thePunderWoman
pushed a commit
that referenced
this pull request
May 20, 2025
thePunderWoman
pushed a commit
that referenced
this pull request
May 20, 2025
Contributor
|
This PR was merged into the repository by commit 1148b7e. The changes were merged into the following branches: main, 19.2.x, 20.0.x |
ajafff
reviewed
May 21, 2025
| @@ -163,6 +165,9 @@ export function toSignal<T, U = undefined>( | |||
| error: (error) => { | |||
| state.set({kind: StateKind.Error, error}); | |||
There was a problem hiding this comment.
we should also unregister the onDestroy callback here, because complete is not called if the Observable terminates with error
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cleanup if the observable completes before the onDestroy fires.
fixes #61511