fix(compiler-cli): Always retain prior results for all files#61487
fix(compiler-cli): Always retain prior results for all files#61487atscott wants to merge 1 commit intoangular:mainfrom
Conversation
|
|
||
| if (existingResults.isComplete) { | ||
| // All data for this file has already been generated, so no need to adopt anything. | ||
| continue; |
There was a problem hiding this comment.
Existing logic so no need to change it now, but this seems suspect to me. If the checker already has state for the source file then it seems incorrect to overwrite that with the old state, without any merging operation. I suspect this logic is irrelevant as no state would be available without having adopted prior results already, at least that's how I'd expect this to work (haven't checked the code)
This change ensures that prior results for all files are retained even when a request is made such that we only need a shim for a single file. Prior to this change, any prior results that were not part of the request were discarded.
bf3a757 to
e73b99a
Compare
This change ensures that prior results for all files are retained even when a request is made such that we only need a shim for a single file. Prior to this change, any prior results that were not part of the request were discarded. PR Close #61487
This change ensures that prior results for all files are retained even when a request is made such that we only need a shim for a single file. Prior to this change, any prior results that were not part of the request were discarded. PR Close #61487
|
This PR was merged into the repository by commit c71adb1. The changes were merged into the following branches: main, 19.2.x, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This change ensures that prior results for all files are retained even when a request is made such that we only need a shim for a single file. Prior to this change, any prior results that were not part of the request were discarded.