Skip to content

fix(common): prevent reading chunks if app is destroyed#61354

Closed
arturovt wants to merge 1 commit intoangular:mainfrom
arturovt:fix/http-destroyed-chunks
Closed

fix(common): prevent reading chunks if app is destroyed#61354
arturovt wants to merge 1 commit intoangular:mainfrom
arturovt:fix/http-destroyed-chunks

Conversation

@arturovt
Copy link
Copy Markdown
Contributor

Prevents processing response chunks after the application has been destroyed.

Prevents processing response chunks after the application has been destroyed.
@pullapprove pullapprove bot requested a review from alxhub May 14, 2025 23:00
@angular-robot angular-robot bot added the area: common Issues related to APIs in the @angular/common package label May 14, 2025
@ngbot ngbot bot added this to the Backlog milestone May 14, 2025
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman removed the request for review from alxhub May 16, 2025 09:53
@thePunderWoman thePunderWoman added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels May 20, 2025
thePunderWoman pushed a commit that referenced this pull request May 20, 2025
Prevents processing response chunks after the application has been destroyed.

PR Close #61354
thePunderWoman pushed a commit that referenced this pull request May 20, 2025
Prevents processing response chunks after the application has been destroyed.

PR Close #61354
@thePunderWoman
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 8768894.

The changes were merged into the following branches: main, 19.2.x, 20.0.x

@arturovt arturovt deleted the fix/http-destroyed-chunks branch May 20, 2025 16:42
@ZixZux
Copy link
Copy Markdown

ZixZux commented May 23, 2025

This commit resulted in a CRITICAL bug!

Now the application can't be started at all. the error occurs: "RuntimeError: NG0200: Circular dependency in DI detected for _ApplicationRef. Find more at https://angular.dev/errors/NG0200".

The source of the problem is the code: private readonly appRef = inject(ApplicationRef);

@thePunderWoman
Copy link
Copy Markdown
Contributor

This commit resulted in a CRITICAL bug!

Now the application can't be started at all. the error occurs: "RuntimeError: NG0200: Circular dependency in DI detected for _ApplicationRef. Find more at https://angular.dev/errors/NG0200".

The source of the problem is the code: private readonly appRef = inject(ApplicationRef);

If you're experiencing a critical bug, file an issue with a minimal reproduction and we'll look at it.

@arturovt
Copy link
Copy Markdown
Contributor Author

@ZixZux we need a minimal reproducible example, I don't have any apps failing with this error.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants