fix(compiler-cli): rename flag for enabling fast type declaration emission#61353
Closed
jonathan-meier wants to merge 1 commit intoangular:mainfrom
Closed
Conversation
AndrewKushnir
approved these changes
May 14, 2025
AndrewKushnir
approved these changes
May 14, 2025
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
Contributor
Contributor
|
Caretaker note: presubmit is "green". // FYI, pushed a rebase to restart the CI (it didn't start automatically for some reasons). |
…ssion Rename the flag `_geminiAllowEmitDeclarationOnly` to `_experimentalAllowEmitDeclarationOnly` as a follow-up on a comment in PR angular#61334.
a6c962b to
0e9689d
Compare
thePunderWoman
approved these changes
May 19, 2025
thePunderWoman
approved these changes
May 19, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: fw-general, public-api
Contributor
|
This PR was merged into the repository by commit 77fa204. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Enabling fast type declaration emission is controlled by the flag
_geminiAllowEmitDeclarationOnly.What is the new behavior?
Renamed the flag
_geminiAllowEmitDeclarationOnlyto_experimentalAllowEmitDeclarationOnlyas a follow-up on a comment in PR #61334.Does this PR introduce a breaking change?