fix(compiler-cli): avoid ECMAScript private field metadata emit#61227
Closed
clydin wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler-cli): avoid ECMAScript private field metadata emit#61227clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
1 task
JoostK
approved these changes
May 9, 2025
packages/compiler-cli/src/ngtsc/annotations/common/test/metadata_spec.ts
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
I now wonder if private fields are supported for Angular-decorated symbols at all. If they are, this change would mean that such fields would generally work except for being JIT-compatible, as that's where the metadata transform (especially for signal-based inputs) is relevant.
Since this change primarily targets non-Angular decorators this point it irrelevant to fix the reported issue so no further actions needed for now.
8a230f0 to
8040007
Compare
The Angular class metadata emit structure does not support the use of private fields. If the class metadata emit is enabled and an ECMAScript private (i.e., `#` prefixed) member contains a decorator, the member will now be excluded from the emitting `setClassMetadata` call. This prevents runtime errors due to invalid syntax.
8040007 to
59d6c99
Compare
Member
|
This PR was merged into the repository by commit c0cd3c2. The changes were merged into the following branches: main, 19.2.x, 20.0.x |
alxhub
pushed a commit
that referenced
this pull request
May 15, 2025
The Angular class metadata emit structure does not support the use of private fields. If the class metadata emit is enabled and an ECMAScript private (i.e., `#` prefixed) member contains a decorator, the member will now be excluded from the emitting `setClassMetadata` call. This prevents runtime errors due to invalid syntax. PR Close #61227
alxhub
pushed a commit
that referenced
this pull request
May 15, 2025
The Angular class metadata emit structure does not support the use of private fields. If the class metadata emit is enabled and an ECMAScript private (i.e., `#` prefixed) member contains a decorator, the member will now be excluded from the emitting `setClassMetadata` call. This prevents runtime errors due to invalid syntax. PR Close #61227
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Angular class metadata emit structure does not support the use of private fields. If the class metadata emit is enabled and an ECMAScript private (i.e.,
#prefixed) member contains a decorator, the member will now be excluded from the emittingsetClassMetadatacall. This prevents runtime errors due to invalid syntax. This class member usage is only permitted if standard ECMAScript decorators are used.Closes #61228