feat(language-service): Support importing the external module's expor…#61122
Closed
ivanwonder wants to merge 1 commit intoangular:mainfrom
Closed
feat(language-service): Support importing the external module's expor…#61122ivanwonder wants to merge 1 commit intoangular:mainfrom
ivanwonder wants to merge 1 commit intoangular:mainfrom
Conversation
14 tasks
atscott
requested changes
May 22, 2025
Contributor
atscott
left a comment
There was a problem hiding this comment.
Thanks for looking into this. Leveraging the TS language service for this is a cool idea.
acd5552 to
9ba7143
Compare
atscott
reviewed
May 23, 2025
atscott
reviewed
May 23, 2025
atscott
reviewed
May 23, 2025
ivanwonder
commented
May 24, 2025
atscott
reviewed
May 27, 2025
atscott
approved these changes
May 27, 2025
352b13f to
606b4da
Compare
atscott
reviewed
May 28, 2025
…t about the angular metadata. This works for the code actions and completion. When the ls wants to complete all importable angular metadata in the template, the ls will invoke the function `ls.getCompletionsAtPosition` and filter the item about the angular. When the developer selects an item, the ls will get the module specifier from the code action return by the `ls.getCompletionEntryDetails`.
606b4da to
4607783
Compare
Contributor
|
This PR was merged into the repository by commit cf55d1b. The changes were merged into the following branches: main |
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t about the angular metadata.
This works for the code actions and completion. When the ls wants to complete all importable angular metadata in the template, the ls will invoke the function
ls.getCompletionsAtPositionand filter the item about the angular. When the developer selects an item, the ls will get the module specifier from the code action return by thels.getCompletionEntryDetails.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information