Skip to content

fix(core): enable stashing only when withEventReplay() is invoked#61077

Closed
arturovt wants to merge 1 commit intoangular:mainfrom
arturovt:refactor/core-stash-event-listener
Closed

fix(core): enable stashing only when withEventReplay() is invoked#61077
arturovt wants to merge 1 commit intoangular:mainfrom
arturovt:refactor/core-stash-event-listener

Conversation

@arturovt
Copy link
Copy Markdown
Contributor

@arturovt arturovt commented Apr 30, 2025

This commit brings the necessary event replay code code in tree-shakable manner.

@pullapprove pullapprove bot requested a review from AndrewKushnir April 30, 2025 21:20
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Apr 30, 2025
@arturovt
Copy link
Copy Markdown
Contributor Author

arturovt commented Apr 30, 2025

@AndrewKushnir this is what we've discussed in this PR (#59635 (comment)).

@ngbot ngbot bot added this to the Backlog milestone Apr 30, 2025
AndrewKushnir
AndrewKushnir reviewed Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arturovt thanks for the PR 👍

The change looks good, one quick comment: I think we should move this logic to an event-replay-related file, for ex. event_delegation_utils.ts, so the code is colocated with the rest of the event replay logic. We can also move the setStashFn and related logic (introduced in a previous PR) there too.

@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 30, 2025
@arturovt arturovt force-pushed the refactor/core-stash-event-listener branch 2 times, most recently from 8f7d01f to fef790b Compare May 1, 2025 08:17
AndrewKushnir
AndrewKushnir reviewed May 1, 2025
View reviewed changes
@arturovt
fix(core): enable stashing only when withEventReplay() is invoked
f2fc8fd 
This commit brings the necessary event replay code code in tree-shakable manner.
@arturovt arturovt force-pushed the refactor/core-stash-event-listener branch from fef790b to f2fc8fd Compare May 1, 2025 21:16
@arturovt arturovt requested a review from AndrewKushnir May 7, 2025 20:42
AndrewKushnir
AndrewKushnir approved these changes May 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring, thanks @arturovt 👍

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 8, 2025
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented May 8, 2025

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit labels May 9, 2025
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented May 9, 2025

Caretaker note: the presubmit is "green" (only unrelated and pre-existing failures).

@alxhub
Copy link
Copy Markdown
Member

alxhub commented May 14, 2025

This PR was merged into the repository by commit a5db6c4.

The changes were merged into the following branches: main, 20.0.x

@alxhub alxhub closed this in a5db6c4 May 14, 2025
alxhub pushed a commit that referenced this pull request May 14, 2025
@arturovt @alxhub
fix(core): enable stashing only when withEventReplay() is invoked (#…
4fe34f4 
…61077)

This commit brings the necessary event replay code code in tree-shakable manner.

PR Close #61077
@arturovt arturovt deleted the refactor/core-stash-event-listener branch May 14, 2025 22:36
arturovt added a commit to arturovt/angular that referenced this pull request May 14, 2025
@arturovt
fix(core): enable stashing only when withEventReplay() is invoked
892f151 
Patch version of angular#61077.
@arturovt arturovt mentioned this pull request May 14, 2025
Closed
alxhub pushed a commit that referenced this pull request May 15, 2025
@arturovt @alxhub
fix(core): enable stashing only when withEventReplay() is invoked (#…
eb53bda 
…61352)

Patch version of #61077.

PR Close #61352
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Jun 17, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@arturovt @AndrewKushnir @alxhub