feat(common): Allow passing ScrollOptions to ViewportScroller #61002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ScrollOptions as an option second argument to ViewportScroller scrollTo* functions. Part of changes needed to address angular#58258
AndrewKushnir
approved these changes
Apr 25, 2025
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
AndrewKushnir
approved these changes
Apr 25, 2025
devversion
approved these changes
Apr 29, 2025
Member
devversion
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
kirjs
approved these changes
Apr 29, 2025
| expect(() => scroller.setHistoryScrollRestoration('manual')).not.toThrow(); | ||
| }); | ||
|
|
||
| it('should not allow overwriting position with options', () => { |
Contributor
There was a problem hiding this comment.
would be nice to have a test where scrollOption actually matter?
Contributor
|
This PR was merged into the repository by commit b7d3f3d. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ScrollOptions as an option second argument to ViewportScroller scrollTo* functions.
Part of changes needed to address #58258