Skip to content

feat(core): rename afterRender to afterEveryRender and stabilize#60999

Closed
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
pkozlowski-opensource:after_render_removal
Closed

feat(core): rename afterRender to afterEveryRender and stabilize#60999
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
pkozlowski-opensource:after_render_removal

Conversation

@pkozlowski-opensource
Copy link
Copy Markdown
Member

This change renames the afterRender to afterEveryRender and marks the renamed API as stable.

BREAKING CHANGE: afterRender was renamed to afterEveryRender.

@pullapprove pullapprove bot requested review from AndrewKushnir, alxhub and kirjs April 25, 2025 09:51
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Apr 25, 2025
@ngbot ngbot bot modified the milestone: Backlog Apr 25, 2025
@pkozlowski-opensource pkozlowski-opensource added target: major This PR is targeted for the next major release state: blocked action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 25, 2025
@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

Will require G3 cleanup before it can land

This change renames the afterRender to afterEveryRender and marks the
renamed API as stable.

BREAKING CHANGE: afterRender was renamed to afterEveryRender.
Copy link
Copy Markdown
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from atscott April 25, 2025 16:08
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pkozlowski-opensource pkozlowski-opensource added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer state: blocked labels Apr 25, 2025
@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

caretaker note: This PR renames afterRender to afterEveryRender. G3 is done but it might have back-slided. If this is the case please don't revert but fix-forward instead by doing the rename.

@mmalerba
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit d8fbb90.

The changes were merged into the following branches: main

@mmalerba mmalerba closed this in d8fbb90 Apr 28, 2025
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants