Skip to content

refactor(platform-server): deprecate the testing entry point#60915

Closed
hybrist wants to merge 1 commit intoangular:mainfrom
hybrist:deprecate-platform-server-testing
Closed

refactor(platform-server): deprecate the testing entry point#60915
hybrist wants to merge 1 commit intoangular:mainfrom
hybrist:deprecate-platform-server-testing

Conversation

@hybrist
Copy link
Copy Markdown
Contributor

@hybrist hybrist commented Apr 18, 2025

DEPRECATED: @angular/platform-server/testing

Use e2e tests to verify SSR behavior instead.

@hybrist hybrist added this to the v20 candidates milestone Apr 18, 2025
@ngbot ngbot bot removed this from the v20 candidates milestone Apr 18, 2025
@pullapprove pullapprove bot requested a review from mmalerba April 18, 2025 16:47
@angular-robot angular-robot bot added detected: deprecation PR contains a commit with a deprecation area: server Issues related to server-side rendering labels Apr 18, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 18, 2025
@hybrist hybrist added target: major This PR is targeted for the next major release and removed area: server Issues related to server-side rendering detected: deprecation PR contains a commit with a deprecation labels Apr 18, 2025
@ngbot ngbot bot removed this from the Backlog milestone Apr 18, 2025
@hybrist hybrist added this to the v20 candidates milestone Apr 18, 2025
@ngbot ngbot bot removed this from the v20 candidates milestone Apr 18, 2025
@hybrist hybrist added the area: server Issues related to server-side rendering label Apr 18, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 18, 2025
@hybrist hybrist added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 18, 2025
@hybrist hybrist force-pushed the deprecate-platform-server-testing branch from 7f9d0a7 to dc4bedd Compare April 18, 2025 17:03
@angular-robot angular-robot bot added the detected: deprecation PR contains a commit with a deprecation label Apr 18, 2025
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 👍

Could you please add a similar deprecation note to the packages/platform-server/testing/PACKAGE.md file as well?

@pullapprove pullapprove bot requested review from atscott and kirjs April 18, 2025 17:13
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

DEPRECATED: `@angular/platform-server/testing`

Use e2e tests to verify SSR behavior instead.
@hybrist hybrist force-pushed the deprecate-platform-server-testing branch from dc4bedd to 470ae6c Compare April 18, 2025 17:16
Copy link
Copy Markdown
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@hybrist hybrist added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 19, 2025
@pkozlowski-opensource
Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 2240a21.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering detected: deprecation PR contains a commit with a deprecation target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants