feat(core): move provideExperimentalCheckNoChangesForDebug to provideCheckNoChangesConfig#60906
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
feat(core): move provideExperimentalCheckNoChangesForDebug to provideCheckNoChangesConfig#60906atscott wants to merge 1 commit intoangular:mainfrom
provideCheckNoChangesConfig#60906atscott wants to merge 1 commit intoangular:mainfrom
Conversation
JoostK
reviewed
Apr 18, 2025
packages/core/src/change_detection/provide_check_no_changes_config.ts
Outdated
Show resolved
Hide resolved
6bc0081 to
ca4b7be
Compare
provideExhaustiveCheckNoChangesForDebugprovideCheckNoChangesConfig
alxhub
approved these changes
Apr 22, 2025
Member
alxhub
left a comment
There was a problem hiding this comment.
Reviewed-for: global-approvers
AndrewKushnir
approved these changes
Apr 23, 2025
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
mmalerba
approved these changes
Apr 23, 2025
Contributor
mmalerba
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
…ideCheckNoChangesConfig` This commit makes several changes changes to the `provideExperimentalCheckNoChangesForDebug` API: * Rename it * Promote to dev preview * Apply the exhaustive behavior to _all_ checkNoChanges runs * Remove `useNgZoneOnStable` option. This wasn't found to be generally more useful than `interval` fixes angular#45612 BREAKING CHANGE: `provideExperimentalCheckNoChangesForDebug` has several breaking changes: * It is renamed to `provideCheckNoChangesConfig` * The behavior applies to _all_ checkNoChanges runs * The `useNgZoneOnStable` option is removed. This wasn't found to be generally more useful than `interval`
Contributor
Author
|
caretaker note: this will require a patch to the components gallery, which uses the old provider name. |
Contributor
|
This PR was merged into the repository by commit e711f99. The changes were merged into the following branches: main |
mmalerba
added a commit
to mmalerba/angular
that referenced
this pull request
Apr 26, 2025
…to `provideCheckNoChangesConfig` (angular#60906)" This reverts commit e711f99.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes several changes changes to the
provideExperimentalCheckNoChangesForDebugAPI:useNgZoneOnStableoption. This wasn't found to be generallymore useful than
intervalfixes #45612
BREAKING CHANGE:
provideExperimentalCheckNoChangesForDebughas severalbreaking changes:
provideCheckNoChangesConfiguseNgZoneOnStableoption is removed. This wasn't found to be generallymore useful than
interval