fix(core): inject migration: replace param with this.#60713
Closed
RussellSprouts wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): inject migration: replace param with this.#60713RussellSprouts wants to merge 1 commit intoangular:mainfrom
RussellSprouts wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
reviewed
Apr 7, 2025
packages/core/schematics/ng-generate/inject-migration/internal.ts
Outdated
Show resolved
Hide resolved
packages/core/schematics/ng-generate/inject-migration/migration.ts
Outdated
Show resolved
Hide resolved
The inject tool inserts `const foo = this.foo` if code in the constructor referenced the constructor parameter `foo`. If `foo` is a readonly property, we can instead replace `foo` with `this.foo`. This allows more properties to be moved out of the constructor with combineMemberInitializers. For now, it only touches initializers, not all of the code in the constructor.
6a52e4c to
b56f902
Compare
crisbeto
approved these changes
Apr 9, 2025
Contributor
|
This PR was merged into the repository by commit 11d441f. The changes were merged into the following branches: main, 19.2.x |
kirjs
pushed a commit
that referenced
this pull request
Apr 10, 2025
The inject tool inserts `const foo = this.foo` if code in the constructor referenced the constructor parameter `foo`. If `foo` is a readonly property, we can instead replace `foo` with `this.foo`. This allows more properties to be moved out of the constructor with combineMemberInitializers. For now, it only touches initializers, not all of the code in the constructor. PR Close #60713
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inject migration tool inserts
const foo = this.fooif code in the constructor references the constructor parameterfoo. Iffoois a readonly property, we can instead replacefoowiththis.foo. This allows more properties to be moved out of the constructor with combineMemberInitializers.For now, it only touches initializers, not all of the code in the constructor.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information