Skip to content

fix(language-service): Do not provide element completions in end tag#60616

Closed
atscott wants to merge 1 commit intoangular:mainfrom
atscott:completions
Closed

fix(language-service): Do not provide element completions in end tag#60616
atscott wants to merge 1 commit intoangular:mainfrom
atscott:completions

Conversation

@atscott
Copy link
Copy Markdown
Contributor

@atscott atscott commented Mar 28, 2025

Element completions should not be provided when the position is in the end tag or between the start and end tags.

fixes angular/vscode-ng-language-service#2157

@angular-robot angular-robot bot added the area: language-service Issues related to Angular's VS Code language service label Mar 28, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 28, 2025
@atscott atscott force-pushed the completions branch 2 times, most recently from 14307fe to 5e38ab3 Compare March 28, 2025 20:12
@atscott atscott requested review from Copilot and devversion March 28, 2025 20:13

This comment was marked as off-topic.

@atscott atscott requested review from Copilot and removed request for Copilot March 28, 2025 20:37

This comment was marked as off-topic.

Element completions should not be provided when the position is in the
end tag or between the start and end tags.

fixes angular/vscode-ng-language-service#2157
@atscott atscott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 2, 2025
@atscott
Copy link
Copy Markdown
Contributor Author

atscott commented Apr 3, 2025

This PR was merged into the repository by commit a22b13f.

The changes were merged into the following branches: main, 19.2.x

@atscott atscott closed this in a22b13f Apr 3, 2025
atscott added a commit that referenced this pull request Apr 3, 2025
…60616)

Element completions should not be provided when the position is in the
end tag or between the start and end tags.

fixes angular/vscode-ng-language-service#2157

PR Close #60616
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect suggestions in HTML templates

3 participants