fix(core): preserve comments in internal inject migration#60588
fix(core): preserve comments in internal inject migration#60588RussellSprouts wants to merge 1 commit intoangular:mainfrom
Conversation
The internal-only combineMemberInitializers option for the inject migration sometimes dropped the doc comments from the members.
| ``, | ||
| `@Directive()`, | ||
| `class MyDir {`, | ||
| ` private foo = inject(Foo);`, |
There was a problem hiding this comment.
My code here loses the whitespace (e.g., blank lines) around the members, which isn't ideal. Let me know if you know of a good way to preserve it.
There was a problem hiding this comment.
Since this is internal-only and we apply auto-formatting, I think it's okay.
| ``, | ||
| `@Directive()`, | ||
| `class MyDir {`, | ||
| ` private foo = inject(Foo);`, |
There was a problem hiding this comment.
Since this is internal-only and we apply auto-formatting, I think it's okay.
The internal-only combineMemberInitializers option for the inject migration sometimes dropped the doc comments from the members. PR Close #60588
|
This PR was merged into the repository by commit 0cd7d3b. The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The internal-only combineMemberInitializers option for the inject migration sometimes dropped the
doc comments from the members.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information