fix(core): remove forceRoot flag for effects#60535
Closed
alxhub wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): remove forceRoot flag for effects#60535alxhub wants to merge 1 commit intoangular:mainfrom
forceRoot flag for effects#60535alxhub wants to merge 1 commit intoangular:mainfrom
Conversation
pkozlowski-opensource
approved these changes
Mar 31, 2025
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
It will need public API goldens update, though (see failing CI)
11f9dcb to
4e50ac1
Compare
pkozlowski-opensource
approved these changes
Mar 31, 2025
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-general
This flag is effectively unused in Angular code that we've seen, and is only serving to complicate the mental model of effects. It could be reintroduced if needed.
4e50ac1 to
34351b4
Compare
Contributor
|
This PR was merged into the repository by commit 43cbc58. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag is effectively unused in Angular code that we've seen, and is only serving to complicate the mental model of effects. It could be reintroduced if needed.