fix(localize): handle @angular/build:karma in ng add#60513
Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
Closed
fix(localize): handle @angular/build:karma in ng add#60513cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat wants to merge 1 commit intoangular:mainfrom
Conversation
`ng add @angular/localize` now also adds the localize polyfill to the configuration of Karma if the `@angular/build:karma` builder is used (which is the default in Angular CLI v20)
a3ec159 to
adb3ca3
Compare
clydin
approved these changes
Mar 21, 2025
Member
|
This PR was merged into the repository by commit 7408a1f. The changes were merged into the following branches: main, 19.2.x |
alxhub
pushed a commit
that referenced
this pull request
Mar 21, 2025
`ng add @angular/localize` now also adds the localize polyfill to the configuration of Karma if the `@angular/build:karma` builder is used (which is the default in Angular CLI v20) PR Close #60513
devversion
pushed a commit
that referenced
this pull request
Mar 24, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
New applications generated by the CLI v20-next use the karma application builder by default.
When running
ng addthis builder is ignored, and the localize polyfill is not added in the test configuration.What is the new behavior?
ng add @angular/localizenow also adds the localize polyfill to the configuration of Karma if the@angular/build:karmabuilder is used (which is the default in Angular CLI v20)Does this PR introduce a breaking change?
Other information