feat(compiler): Add extended diagnostic to warn when the track functi…#60495
Closed
eneajaho wants to merge 1 commit intoangular:mainfrom
Closed
feat(compiler): Add extended diagnostic to warn when the track functi…#60495eneajaho wants to merge 1 commit intoangular:mainfrom
eneajaho wants to merge 1 commit intoangular:mainfrom
Conversation
Contributor
Author
|
TODOs:
|
JeanMeche
reviewed
Mar 21, 2025
dc5c3a4 to
9bcb2a0
Compare
JeanMeche
reviewed
Mar 23, 2025
9bcb2a0 to
14ad13f
Compare
Member
|
This doesn't pass the presubmit, it correctly flagged un-invoked functions. |
JeanMeche
reviewed
Mar 23, 2025
0506479 to
f8af359
Compare
devversion
approved these changes
Mar 25, 2025
Member
devversion
left a comment
There was a problem hiding this comment.
LGTM from my side, adding @crisbeto in case he has other thoughts.
f8af359 to
e732838
Compare
crisbeto
approved these changes
Mar 26, 2025
Member
|
FYI this will require a TGP, because extended diagnostics can break existing targets. |
Member
|
I'll take care of the cleanup. |
6 tasks
e732838 to
948c94b
Compare
kirjs
approved these changes
Mar 27, 2025
Contributor
kirjs
left a comment
There was a problem hiding this comment.
Looks great, thanks for adding this
Reviewed-for: public-api
948c94b to
6e614f2
Compare
6e614f2 to
7e7b170
Compare
alfaproject
reviewed
Apr 8, 2025
Contributor
There was a problem hiding this comment.
I actually hope you guys will reevaluate this decision. It should 100% produce a warning
This MR is already good as is, but this test tickles my OCD d:
7e7b170 to
cbea221
Compare
Member
|
TGP is "green". |
Contributor
|
This PR was merged into the repository by commit 7a97176. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on is not called on @for blocks
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Fixes #58264
What is the current behavior?
Passing just the function name to the track function basically will make the for loop recreate the list everytime. The function need to be called.
What is the new behavior?
A template diagnostic will warn the developer that they need to call the function in the track part of a @for block for desired performance outcome.
Does this PR introduce a breaking change?
Other information