fix(platform-browser): ensure platformBrowserTesting includes platformBrowser providers#60480
Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Closed
fix(platform-browser): ensure platformBrowserTesting includes platformBrowser providers#60480alan-agius4 wants to merge 1 commit intoangular:mainfrom
platformBrowserTesting includes platformBrowser providers#60480alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Mar 20, 2025
`platformBrowserTesting` currently does not include the right providers. See: angular/angular#60480
5c2ffcd to
5bd6a04
Compare
platformBrowserTesting includes platformBrowser providersplatformBrowserTesting includes platformBrowser providers
5bd6a04 to
55f6222
Compare
55f6222 to
6466e9f
Compare
…formBrowser` providers Previously, `platformBrowserTesting` did not include any `platformBrowser` providers, causing an inconsistency with `platformBrowserDynamicTesting`. This update resolves the issue by restructuring platform inheritance to ensure proper provider inclusion: - `platformCore → platformBrowser → platformBrowserTesting` - `platformBrowser → platformBrowserDynamic → platformBrowserDynamicTesting` Now, `platformBrowserTesting` correctly inherits from `platformBrowser`, aligning with the expected behavior.
6466e9f to
72ffdc6
Compare
Contributor
Author
|
Caretaker note: This requires a build file update in G3. See cl/738717205 also the API changes are just import renames. |
Contributor
Author
alan-agius4
added a commit
to angular/angular-cli
that referenced
this pull request
Mar 20, 2025
`platformBrowserTesting` currently does not include the right providers. See: angular/angular#60480
Member
|
This PR was merged into the repository by commit 70bdb88. The changes were merged into the following branches: main, 19.2.x |
alxhub
pushed a commit
that referenced
this pull request
Mar 20, 2025
…formBrowser` providers (#60480) Previously, `platformBrowserTesting` did not include any `platformBrowser` providers, causing an inconsistency with `platformBrowserDynamicTesting`. This update resolves the issue by restructuring platform inheritance to ensure proper provider inclusion: - `platformCore → platformBrowser → platformBrowserTesting` - `platformBrowser → platformBrowserDynamic → platformBrowserDynamicTesting` Now, `platformBrowserTesting` correctly inherits from `platformBrowser`, aligning with the expected behavior. PR Close #60480
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
platformBrowserTestingdid not include anyplatformBrowserproviders, causing an inconsistency withplatformBrowserDynamicTesting.This update resolves the issue by restructuring platform inheritance to ensure proper provider inclusion:
platformCore → platformBrowser → platformBrowserTestingplatformBrowser → platformBrowserDynamic → platformBrowserDynamicTestingNow,
platformBrowserTestingcorrectly inherits fromplatformBrowser, aligning with the expected behavior.Note: This change is needed to remove
@angular/platform-browser-dynamicfrom newly generated apps.