Closed
Conversation
2b0888a to
db7c556
Compare
`TestBed.get` isn't type safe and has been deprecated for several years now. These changes remove it from the public API and a follow-up change will add an automated migration to `TestBed.inject`. BREAKING CHANGE: * `TestBed.get` has been removed. Use `TestBed.inject` instead.
Adds a migration that will move users off the deprecated `TestBed.get` method.
db7c556 to
2abad2f
Compare
pkozlowski-opensource
approved these changes
Mar 17, 2025
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-general
Reviewed-for: fw-security
devversion
approved these changes
Mar 17, 2025
Member
devversion
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
jelbourn
approved these changes
Mar 17, 2025
Contributor
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-security
josephperrott
approved these changes
Mar 17, 2025
Member
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-security
kirjs
reviewed
Mar 17, 2025
| ); | ||
|
|
||
| await runMigration(); | ||
| expect(tree.readContent('/test.ts')).toContain( |
Contributor
There was a problem hiding this comment.
Super nit, but maybe expect it not to contain TestBed.get?
kirjs
approved these changes
Mar 17, 2025
AndrewKushnir
approved these changes
Mar 17, 2025
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
Member
Author
|
Passing TGP, once a handful of clients are cleaned up. |
Member
|
This PR was merged into the repository by commit 34f0453. The changes were merged into the following branches: main |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Mar 19, 2025
Adds a migration that will move users off the deprecated `TestBed.get` method. PR Close #60414
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestBed.getisn't type safe and has been deprecated for several years now. These changes remove it from the public API.BREAKING CHANGE:
TestBed.gethas been removed. UseTestBed.injectinstead.