fix(core): execute timer trigger outside zone#60392
Closed
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): execute timer trigger outside zone#60392thePunderWoman wants to merge 1 commit intoangular:mainfrom
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Conversation
atscott
reviewed
Mar 14, 2025
e6366fa to
0f5cc98
Compare
This should prevent defer timers from impacting app stability by executing them outside of the zone, similar to other defer triggers. fixes: angular#60373
0f5cc98 to
768a9e1
Compare
atscott
approved these changes
Mar 14, 2025
Member
|
This PR was merged into the repository by commit b8daf47. The changes were merged into the following branches: main, 19.2.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Mar 14, 2025
| deferred: Array<number | VoidFunction> = []; | ||
|
|
||
| add(delay: number, callback: VoidFunction) { | ||
| add(delay: number, callback: VoidFunction, ngZone: NgZone) { |
Contributor
There was a problem hiding this comment.
Since TimerScheduler is an injectable class, we could avoid passing ngZone as an argument, but instead just inject it in the class directly (using the inject function).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should prevent defer timers from impacting app stability by executing them outside of the zone, similar to other defer triggers. This should also affect
minimumandaftertime values in placeholder and loading templates for defer blocks, as they use the sameTimerScheduler.Does this PR introduce a breaking change?