Skip to content

feat(core): add hook for producer creation side effects #60333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mturco wants to merge 1 commit into from
Closed

feat(core): add hook for producer creation side effects #60333

mturco wants to merge 1 commit into from
+99 −11

Conversation

@mturco
Copy link
Contributor

@mturco mturco commented Mar 11, 2025 •
edited
Loading

Adds a hook in the same style as postSignalSetFn for running side effects when a producer has been created. This hook will be passed the reactive node being created.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

No hook exists to notify frameworks when producers are created.

Issue Number: N/A

What is the new behavior?

A hook exists to notify frameworks when producers are created.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mturco mturco requested a review from alxhub March 11, 2025 21:21
@pullapprove pullapprove bot requested review from AndrewKushnir and crisbeto March 11, 2025 21:21
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Mar 11, 2025
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Mar 11, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 11, 2025
@AndrewKushnir AndrewKushnir requested review from pkozlowski-opensource and removed request for AndrewKushnir March 11, 2025 22:12
@mturco mturco force-pushed the reactive-hooks branch 2 times, most recently from 6dc0d6d to 814a2e6 Compare March 13, 2025 15:11
crisbeto
crisbeto approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@mturco
Copy link
Contributor Author

mturco commented Mar 17, 2025

Passing TGP: http://test/OCL:735889127:BASE:737622333:1742224972919:38a8f2c6

alxhub
alxhub reviewed Mar 17, 2025
View reviewed changes
packages/core/primitives/signals/src/signal.ts Outdated
Copy link
Member

@alxhub alxhub Mar 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call this for linkedSignal as well?

Copy link
Contributor Author

@mturco mturco Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Done

alxhub
alxhub approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: primitives

@mturco
feat(core): add hook for producer creation side effects
f8a2201 
Adds a hook in the same style as `postSignalSetFn` for running side effects when a producer has been created. This hook will be passed the reactive node being created.
thePunderWoman
thePunderWoman approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 18, 2025
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Mar 18, 2025

This PR was merged into the repository by commit 22d3f05.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 18, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@alxhub alxhub alxhub approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit requires: TGP This PR requires a passing TGP before merging is allowed target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@mturco @pkozlowski-opensource @thePunderWoman @alxhub @crisbeto