feat(compiler-cli): add extended diagnostic for invalid nullish coalescing #60279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePunderWoman
approved these changes
Mar 17, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
Author
|
CARETAKER: patch cl/737806124 |
…scing The semantics for nullish coalescing (`??`) in Javascript/Typescript differ slightly from the semantics in Angular templates. Mixing nullish coalescing with logical and/or without parentheses is an error in Javascript. This PR adds an extended diagnostic that can be enabled to treat it as an error in Angular templates as well.
crisbeto
approved these changes
Mar 18, 2025
crisbeto
approved these changes
Mar 18, 2025
pkozlowski-opensource
approved these changes
Mar 19, 2025
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Member
|
This PR was merged into the repository by commit bec1610. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics for nullish coalescing (
??) in Javascript/Typescriptdiffer slightly from the semantics in Angular templates. Mixing nullish
coalescing with logical and/or without parentheses is an error in
Javascript. This PR adds an extended diagnostic that can be enabled to
treat it as an error in Angular templates as well.