fix(core): fix typing on injector.get to omit 'any'#60202
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): fix typing on injector.get to omit 'any'#60202atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
7d79975 to
2e99fda
Compare
2e99fda to
c686345
Compare
This commit further restricts the deprecated type on injector.get to exclude all but `string`. Progresses towards angular#48408 BREAKING CHANGE: The `any` overload has been removed from `injector.get`. It now only supports `ProviderToken<T>` and (deprecated since v4) `string`.
c686345 to
65cd39a
Compare
Contributor
Author
|
TGP is green with 1 fix submitted |
pkozlowski-opensource
approved these changes
Mar 10, 2025
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit ff772d7. The changes were merged into the following branches: main |
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit further restricts the deprecated type on injector.get to exclude all but
string. Progresses towards #48408BREAKING CHANGE: The
anyoverload has been removed frominjector.get. It now only supportsProviderToken<T>and (deprecated since v4)string.