refactor(compiler): stop down-leveling nullish coalescing #60060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa6d7ec to
05fcf72
Compare
Stop down-leveling the nullish coalescing (`??`) operator in templates. Depending on the ES version typescript may still down-level it.
Updates tests to reflect the fact that we no loger down-level nullish coalescing.
Fixes outputted nullish coalescing expressions to not drop parentheses when it would change the meaning of the expression.
crisbeto
approved these changes
Mar 4, 2025
Contributor
Author
|
This PR was merged into the repository by commit ffb19e6. The changes were merged into the following branches: main |
mmalerba
added a commit
that referenced
this pull request
Mar 4, 2025
Updates tests to reflect the fact that we no loger down-level nullish coalescing. PR Close #60060
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop down-leveling the nullish coalescing (
??) operator in templates. Depending on the ES version typescript may still down-level it.Note: This does not change the semantics of
??in templates, which currently doesn't match the semantics in TS/JS, as this would be a much more breaking change. The main difference is thata && b ?? cis treated the same asa && (b ?? c)in our template, while its considered invalid in TS/JS