fix(core): Catch and report rejections in async function of `PendingT…#60044
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): Catch and report rejections in async function of `PendingT…#60044atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
AndrewKushnir
approved these changes
Feb 25, 2025
3702b3b to
c7894af
Compare
…asks.run` This commit ensures that rejections of the promise of the async function passed to `PendingTasks.run` are not dangling and get reported to the application error handler. This prevents what would likely be a common dangling promise that could end up crashing the node process. BREAKING CHANGE: `PendingTasks.run` no longer returns the result of the async function. If this behavior is desired, it can be re-implemented manually with the `PendingTasks.add`. Be aware, however, that promise rejections will need to be handled or they can cause the node process to shut down when using SSR.
c7894af to
ce981a4
Compare
thePunderWoman
approved these changes
Feb 26, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
AndrewKushnir
approved these changes
Feb 26, 2025
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit 7232ce5. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…asks.run`
This commit ensures that rejections of the promise of the async function passed to
PendingTasks.runare not dangling and get reported to the application error handler. This prevents what would likely be a common dangling promise that could end up crashing the node process.BREAKING CHANGE:
PendingTasks.runno longer returns the result of the async function. If this behavior is desired, it can be re-implemented manually with thePendingTasks.add. Be aware, however, that promise rejections will need to be handled or they can cause the node process to shut down when using SSR.