Closed
Conversation
Fixes that the control flow migration wasn't checking the content of pre-existing control flow nodes for dependencies. Fixes angular#59846.
Fixes that the control flow migration wasn't accounting for `@let` when determining which symbols are used.
Member
Author
|
You should be able to update to the new version, run the command and then roll back the update. |
Contributor
|
This PR was merged into the repository by commit aa285c5. The changes were merged into the following branches: main, 19.1.x |
atscott
pushed a commit
that referenced
this pull request
Feb 12, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues with the control flow migration:
fix(migrations): count used dependencies inside existing control flow
Fixes that the control flow migration wasn't checking the content of pre-existing control flow nodes for dependencies.
fix(migrations): account for let declarations in control flow migration
Fixes that the control flow migration wasn't accounting for
@letwhen determining which symbols are used.Fixes #59846.