Closed
Conversation
820e9a5 to
5540198
Compare
clydin
approved these changes
Feb 11, 2025
Adjusts the code we generate for HMR so that it passes in the HMR ID and `import.meta` to the `replaceMetadata` call. This is necessary so we can do better logging of errors.
Integrates angular/angular-cli#29510 which allows us to invalidate the data in the dev server for a component if a replacement threw an error.
5540198 to
5e5e7c9
Compare
atscott
pushed a commit
that referenced
this pull request
Feb 12, 2025
…59854) Integrates angular/angular-cli#29510 which allows us to invalidate the data in the dev server for a component if a replacement threw an error. PR Close #59854
Contributor
|
This PR was merged into the repository by commit b0266bd. The changes were merged into the following branches: main, 19.1.x |
atscott
pushed a commit
that referenced
this pull request
Feb 12, 2025
…59854) Integrates angular/angular-cli#29510 which allows us to invalidate the data in the dev server for a component if a replacement threw an error. PR Close #59854
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following changes:
refactor(compiler): pass more information to HMR replacement function
Adjusts the code we generate for HMR so that it passes in the HMR ID and
import.metato thereplaceMetadatacall. This is necessary so we can do better logging of errors.fix(core): invalidate HMR component if replacement throws an error
Integrates angular/angular-cli#29510 which allows us to invalidate the data in the dev server for a component if a replacement threw an error.