fix(common): clean up urlChanges subscribers when root scope is destroyed#59703
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
fix(common): clean up urlChanges subscribers when root scope is destroyed#59703arturovt wants to merge 1 commit intoangular:mainfrom
urlChanges subscribers when root scope is destroyed#59703arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
602ad16 to
9155c8d
Compare
devversion
approved these changes
Jan 27, 2025
devversion
reviewed
Jan 27, 2025
9155c8d to
bd96ff1
Compare
Contributor
Author
|
@devversion I checked the angular.js code and you were right. I also left a comment for clarification. |
04366fa to
bb3d59f
Compare
bb3d59f to
61948c1
Compare
devversion
approved these changes
Feb 13, 2025
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
Contributor
|
@arturovt Can you rebase this? There are some tests failing, but I suspect they're just out of date / unrelated. |
61948c1 to
71e7422
Compare
Contributor
Author
Done. |
…troyed In this commit, the `urlChanges` subject is completed to release all active observers when the root scope is destroyed. Previously, subscribing to the `urlChanges` subject caused the subscriber to capture `this`, resulting in a memory leak after the root scope was destroyed.
71e7422 to
624ff0d
Compare
devversion
approved these changes
Feb 15, 2025
thePunderWoman
pushed a commit
that referenced
this pull request
Feb 18, 2025
…troyed (#59703) In this commit, the `urlChanges` subject is completed to release all active observers when the root scope is destroyed. Previously, subscribing to the `urlChanges` subject caused the subscriber to capture `this`, resulting in a memory leak after the root scope was destroyed. PR Close #59703
Contributor
|
This PR was merged into the repository by commit 7bd4be0. The changes were merged into the following branches: main, 19.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, the
urlChangessubject is completed to release all active observers when the root scope is destroyed. Previously, subscribing to theurlChangessubject caused the subscriber to capturethis, resulting in a memory leak after the root scope was destroyed.