Skip to content

fix(compiler): update @ng/component URL to be relative#59620

Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:hmr-url
Closed

fix(compiler): update @ng/component URL to be relative#59620
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:hmr-url

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

This change is required to resolve angular/angular-cli#29248 and works in conjunction with angular/angular-cli#29386. It ensures that HMR (Hot Module Replacement) functions correctly with base href, proxies, and other advanced development setups.

@alan-agius4 alan-agius4 added area: compiler Issues related to `ngc`, Angular's template compiler core: hot module replacement (HMR) labels Jan 20, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 20, 2025
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jan 20, 2025
@pullapprove pullapprove bot requested a review from alxhub January 20, 2025 07:36
@alan-agius4 alan-agius4 changed the title ix(compiler): update @ng/component URL to be relative fix(compiler): update @ng/component URL to be relative Jan 20, 2025
This change is required to resolve angular/angular-cli#29248 and works in conjunction with angular/angular-cli#29386. It ensures that HMR (Hot Module Replacement) functions correctly with `base href`, proxies, and other advanced development setups.
@alan-agius4 alan-agius4 requested review from crisbeto and removed request for alxhub January 20, 2025 07:37
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 20, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 20, 2025
@pkozlowski-opensource
Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 30c4404.

The changes were merged into the following branches: main, 19.1.x

pkozlowski-opensource pushed a commit that referenced this pull request Jan 20, 2025
This change is required to resolve angular/angular-cli#29248 and works in conjunction with angular/angular-cli#29386. It ensures that HMR (Hot Module Replacement) functions correctly with `base href`, proxies, and other advanced development setups.

PR Close #59620
@alan-agius4 alan-agius4 deleted the hmr-url branch January 20, 2025 13:04
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
This change is required to resolve angular/angular-cli#29248 and works in conjunction with angular/angular-cli#29386. It ensures that HMR (Hot Module Replacement) functions correctly with `base href`, proxies, and other advanced development setups.

PR Close angular#59620
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler core: hot module replacement (HMR) target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

application builder not loading css from localhost correctly with ng serve when using remote dev with HMR

3 participants