feat(core): pass signal node to throwInvalidWriteToSignalErrorFn#59600
Closed
mturco wants to merge 1 commit intoangular:mainfrom
Closed
feat(core): pass signal node to throwInvalidWriteToSignalErrorFn#59600mturco wants to merge 1 commit intoangular:mainfrom
mturco wants to merge 1 commit intoangular:mainfrom
Conversation
mturco
commented
Jan 17, 2025
Updates the signature of the `throwInvalidWriteToSignalError` to take the signal node in question and pass it along to the throwInvalidWriteToSignalErrorFn handler function. This allows the handler to e.g. include the signal name in error messaging.
461d2b8 to
4a4d2a1
Compare
thePunderWoman
approved these changes
Jan 17, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
This looks useful!
reviewed-for: public-api, primitives
kirjs
approved these changes
Jan 22, 2025
kirjs
approved these changes
Jan 22, 2025
Contributor
|
reviewed-for: public-api, primitives |
pkozlowski-opensource
approved these changes
Feb 12, 2025
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-primitives
Contributor
|
@mturco Looks like there's a few consistently failing targets. Unclear if they are related though. Can you take a look? |
Contributor
Author
|
@thePunderWoman synced and reran the TGP and it's green now! |
Contributor
|
TESTED=TGP |
Contributor
|
This PR was merged into the repository by commit 2588985. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the signature of the
throwInvalidWriteToSignalErrorto take the signal node in question and pass it along to the throwInvalidWriteToSignalErrorFn handler function. This allows the handler to e.g. include the signal name in error messaging.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
throwInvalidWriteToSignalErrorcallsthrowInvalidWriteToSignalErrorFnwith no arguments.Issue Number: N/A
What is the new behavior?
throwInvalidWriteToSignalErrorcallsthrowInvalidWriteToSignalErrorFnwith the signal node as an argument.Does this PR introduce a breaking change?
Other information