feat(compiler-cli): add diagnostic for uninvoked functions in text interpolation by RafaelJCamara · Pull Request #59191 · angular/angular

RafaelJCamara · 2024-12-14T10:31:53Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.dev application / infrastructure changes
Other... Please describe:

What is the current behavior?

We don't perform this check whenever we have an uninvoked function in a text interpolation.

Issue Number: #59157

What is the new behavior?

Whenever we have an uninvoked function in a text interpolation, a warning is triggered (NG8114).

Does this PR introduce a breaking change?

Yes
No

...ks/uninvoked_function_in_text_interpolation/uninvoked_function_in_text_interpolation_spec.ts

adev/src/content/reference/extended-diagnostics/NG8114.md

JeanMeche · 2024-12-14T16:36:15Z

Could you also make sure to check the linter failures, thank you.

github-actions · 2024-12-14T16:43:30Z

Deployed adev-preview for b3607ab to: https://ng-dev-previews-fw--pr-angular-angular-59191-adev-prev-ehyguwsu.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

JeanMeche · 2024-12-14T16:45:04Z

Also, we need to add the entry to adev/src/content/reference/extended-diagnostics/overview.md.

RafaelJCamara · 2024-12-18T22:59:44Z

@JeanMeche I think I've addressed all the comments!

packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts

...ks/uninvoked_function_in_text_interpolation/uninvoked_function_in_text_interpolation_spec.ts

RafaelJCamara · 2024-12-19T07:37:53Z

Whenever you have time, please look at the new changes @JeanMeche!

JoostK

I suspect these points may have originated in the signal check, but mentioning them here anyway.

...er-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_text_interpolation/index.ts

RafaelJCamara · 2024-12-20T17:30:19Z

@JeanMeche @JoostK Changes have been applied and are ready to be blasted with another review!

RafaelJCamara · 2025-01-14T11:16:57Z

@alxhub @JeanMeche @JoostK Do you think this is ready for a review?

JoostK

This looks correct for me

adev/src/content/reference/extended-diagnostics/NG8114.md

...ks/uninvoked_function_in_text_interpolation/uninvoked_function_in_text_interpolation_spec.ts

JeanMeche · 2025-02-27T01:25:41Z

Case you rebase your PR and take the previous comments into account ? Thank you.

JeanMeche · 2025-06-27T11:12:37Z

The last fix CL from the previous TGP was submitted.

This should be good to go.

JeanMeche · 2025-06-27T12:08:02Z

TESTED=TGP

JeanMeche

reviewed-for: public-api

thePunderWoman

reviewed-for: public-api

AndrewKushnir · 2025-07-15T14:54:27Z

@JeanMeche @thePunderWoman I'd like to propose running a new TGP to make sure there are no regressions. Could you please start a new TGP when you get a chance?

JeanMeche · 2025-07-15T14:55:34Z

I'll take care of it tomorrow morning !

JeanMeche · 2025-07-16T15:53:29Z

TESTED=TGP

kirjs · 2025-07-16T20:30:38Z

This PR was merged into the repository by commit 5abfe4a.

The changes were merged into the following branches: main

angular-automatic-lock-bot · 2025-08-16T00:13:12Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

pullapprove bot requested a review from alxhub December 14, 2024 10:32

angular-robot bot added the detected: feature PR contains a feature commit label Dec 14, 2024

JeanMeche reviewed Dec 14, 2024

View reviewed changes

...ks/uninvoked_function_in_text_interpolation/uninvoked_function_in_text_interpolation_spec.ts Outdated Show resolved Hide resolved

JeanMeche reviewed Dec 14, 2024

View reviewed changes

adev/src/content/reference/extended-diagnostics/NG8114.md Outdated Show resolved Hide resolved

JeanMeche added the adev: preview label Dec 14, 2024

angular-robot bot added the area: docs Related to the documentation label Dec 18, 2024

ngbot bot added this to the Backlog milestone Dec 18, 2024

RafaelJCamara requested a review from JeanMeche December 18, 2024 22:59

JeanMeche reviewed Dec 18, 2024

View reviewed changes

packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts Outdated Show resolved Hide resolved

JeanMeche reviewed Dec 18, 2024

View reviewed changes

...ks/uninvoked_function_in_text_interpolation/uninvoked_function_in_text_interpolation_spec.ts Outdated Show resolved Hide resolved

RafaelJCamara requested a review from JeanMeche December 19, 2024 08:07

JoostK reviewed Dec 19, 2024

View reviewed changes

...er-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_text_interpolation/index.ts Outdated Show resolved Hide resolved

...er-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_text_interpolation/index.ts Outdated Show resolved Hide resolved

RafaelJCamara requested a review from JoostK December 19, 2024 19:21

JoostK reviewed Dec 19, 2024

View reviewed changes

...er-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_text_interpolation/index.ts Outdated Show resolved Hide resolved

RafaelJCamara requested a review from JoostK December 19, 2024 21:54

jelbourn mentioned this pull request Jan 29, 2025

Add extended diagnostic for referencing a function in a text interpolation #59157

Closed

JoostK reviewed Feb 6, 2025

View reviewed changes

adev/src/content/reference/extended-diagnostics/NG8114.md Outdated Show resolved Hide resolved

...ks/uninvoked_function_in_text_interpolation/uninvoked_function_in_text_interpolation_spec.ts Outdated Show resolved Hide resolved

JeanMeche force-pushed the RafaelJCamara/59157-func-text-interpolation branch from 8230854 to 192b848 Compare March 4, 2025 21:20

angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 4, 2025

JeanMeche force-pushed the RafaelJCamara/59157-func-text-interpolation branch 2 times, most recently from b648bc4 to 04791c9 Compare March 4, 2025 21:36

angular-robot bot removed the area: docs Related to the documentation label Mar 4, 2025

JeanMeche requested a review from crisbeto June 27, 2025 11:12

crisbeto approved these changes Jul 15, 2025

View reviewed changes

pullapprove bot requested review from kirjs, mmalerba and thePunderWoman July 15, 2025 09:18

JeanMeche approved these changes Jul 15, 2025

View reviewed changes

thePunderWoman approved these changes Jul 15, 2025

View reviewed changes

thePunderWoman removed request for kirjs and mmalerba July 15, 2025 14:24

thePunderWoman added the action: merge The PR is ready for merge by the caretaker label Jul 15, 2025

AndrewKushnir added requires: TGP This PR requires a passing TGP before merging is allowed action: global presubmit The PR is in need of a google3 global presubmit labels Jul 15, 2025

pullapprove bot removed action: global presubmit The PR is in need of a google3 global presubmit requires: TGP This PR requires a passing TGP before merging is allowed labels Jul 15, 2025

AndrewKushnir added requires: TGP This PR requires a passing TGP before merging is allowed action: global presubmit The PR is in need of a google3 global presubmit and removed action: merge The PR is ready for merge by the caretaker labels Jul 15, 2025

pullapprove bot removed action: global presubmit The PR is in need of a google3 global presubmit requires: TGP This PR requires a passing TGP before merging is allowed labels Jul 15, 2025

JeanMeche added the action: merge The PR is ready for merge by the caretaker label Jul 16, 2025

kirjs closed this in 5abfe4a Jul 16, 2025

angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 16, 2025

Conversation

RafaelJCamara commented Dec 14, 2024

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Uh oh!

Uh oh!

Uh oh!

JeanMeche commented Dec 14, 2024

Uh oh!

github-actions bot commented Dec 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JeanMeche commented Dec 14, 2024

Uh oh!

RafaelJCamara commented Dec 18, 2024

Uh oh!

Uh oh!

Uh oh!

RafaelJCamara commented Dec 19, 2024

Uh oh!

JoostK left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RafaelJCamara commented Dec 20, 2024

Uh oh!

RafaelJCamara commented Jan 14, 2025

Uh oh!

JoostK left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JeanMeche commented Feb 27, 2025

Uh oh!

JeanMeche commented Jun 27, 2025

Uh oh!

JeanMeche commented Jun 27, 2025

Uh oh!

JeanMeche left a comment

Choose a reason for hiding this comment

Uh oh!

thePunderWoman left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir commented Jul 15, 2025

Uh oh!

JeanMeche commented Jul 15, 2025

Uh oh!

JeanMeche commented Jul 16, 2025

Uh oh!

kirjs commented Jul 16, 2025

Uh oh!

angular-automatic-lock-bot bot commented Aug 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Dec 14, 2024 •

edited

Loading