fix(core): Snapshots can return nullish values; don't run the snapsho…#59073
Closed
arielbackenroth wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): Snapshots can return nullish values; don't run the snapsho…#59073arielbackenroth wants to merge 1 commit intoangular:mainfrom
arielbackenroth wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
approved these changes
Dec 5, 2024
…if they return a nullish/falsey value. Snapshots can return nullish values; don't run the snapshotted function if the snapshotted function returns a nullish/falsey value.
Member
|
This PR was merged into the repository by commit 30e6760. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…if they return a nullish/falsey value. (angular#59073) Snapshots can return nullish values; don't run the snapshotted function if the snapshotted function returns a nullish/falsey value. PR Close angular#59073
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(core): Snapshots can return nullish values; don't run the snapshotted function twice if it does.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information