fix(compiler-cli): account for multiple generated namespace imports in HMR#58924
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler-cli): account for multiple generated namespace imports in HMR#58924crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
JoostK
reviewed
Nov 27, 2024
packages/compiler-cli/src/ngtsc/hmr/src/extract_dependencies.ts
Outdated
Show resolved
Hide resolved
eb1cc91 to
6175b44
Compare
Member
Author
|
👍 feedback has been addressed. |
…n HMR The current HMR compiler assumes that there will only be one namespace import in the generated code (`@angular/core`). This is incorrect, because the compiler may need to generate additional imports in some cases (e.g. importing directives through a module). These changes adjust the compiler to capture all the namespaces in an array and pass them along. Fixes angular#58915.
6175b44 to
e46002d
Compare
AndrewKushnir
approved these changes
Nov 27, 2024
clydin
approved these changes
Nov 28, 2024
Member
|
This PR was merged into the repository by commit f280467. The changes were merged into the following branches: main, 19.0.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Nov 28, 2024
…n HMR (#58924) The current HMR compiler assumes that there will only be one namespace import in the generated code (`@angular/core`). This is incorrect, because the compiler may need to generate additional imports in some cases (e.g. importing directives through a module). These changes adjust the compiler to capture all the namespaces in an array and pass them along. Fixes #58915. PR Close #58924
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current HMR compiler assumes that there will only be one namespace import in the generated code (
@angular/core). This is incorrect, because the compiler may need to generate additional imports in some cases (e.g. importing directives through a module). These changes adjust the compiler to capture all the namespaces in an array and pass them along.Fixes #58915.