Skip to content

fix(migrations): take care of tests that import both HttpClientModule & HttpClientTestingModule. #58777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeanMeche wants to merge 1 commit into from
Closed

fix(migrations): take care of tests that import both HttpClientModule & HttpClientTestingModule. #58777

JeanMeche wants to merge 1 commit into from
+57 −23

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Nov 20, 2024 •
edited
Loading

While having both HttpClientModule & HttpClientTestingModule serves no real purpose (HttpClientTestingModule imports HttpClientModule), some code bases can have those 2 together and the migration can be quite breaking without this fix.

fixes #58536

@angular-robot angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Nov 20, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 20, 2024
@JeanMeche JeanMeche added the target: lts This PR is targeting a version currently in long-term support label Nov 20, 2024
@JeanMeche JeanMeche force-pushed the fix/htttp-provider-migrations branch from 623e155 to ac0e16e Compare November 20, 2024 15:15
@JeanMeche JeanMeche changed the title fix(migrations): take care of tests that import both `HttpClientModul… fix(migrations): take care of tests that import both HttpClientModule & HttpClientTestingModule. Nov 20, 2024
@JeanMeche JeanMeche marked this pull request as ready for review November 20, 2024 20:08
@pullapprove pullapprove bot requested a review from devversion November 20, 2024 20:08
devversion
devversion previously approved these changes Nov 21, 2024
View reviewed changes
@JeanMeche JeanMeche force-pushed the fix/htttp-provider-migrations branch from ac0e16e to 33ba20e Compare November 21, 2024 12:37
@JeanMeche
fix(migrations): take care of tests that import both HttpClientModule…
0e162d9 
… & HttpClientTestingModule.

While having both `HttpClientModule` & `HttpClientTestingModule` serves no real purpose (`HttpClientTestingModule` imports `HttpClientModule`), some code bases can have those 2 together and the migration can be quite breaking.

fixes angular#58536
@JeanMeche JeanMeche force-pushed the fix/htttp-provider-migrations branch from 33ba20e to 0e162d9 Compare November 21, 2024 13:03
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Nov 21, 2024
@JeanMeche JeanMeche mentioned this pull request Nov 21, 2024
Closed
1 task
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Nov 21, 2024
thePunderWoman pushed a commit that referenced this pull request Nov 22, 2024
@JeanMeche @thePunderWoman
fix(migrations): take care of tests that import both HttpClientModule…
06d70a2 
… & HttpClientTestingModule. (#58777)

While having both `HttpClientModule` & `HttpClientTestingModule` serves no real purpose (`HttpClientTestingModule` imports `HttpClientModule`), some code bases can have those 2 together and the migration can be quite breaking.

fixes #58536

PR Close #58777
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Nov 22, 2024

This PR was merged into the repository by commit 06d70a2.

The changes were merged into the following branches: 18.2.x

@sysmat
Copy link

sysmat commented Dec 3, 2024

what that mean, that now in tests we can just provide provideHttpClientTesting()?

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jan 3, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: lts This PR is targeting a version currently in long-term support

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@JeanMeche @thePunderWoman @sysmat @devversion