fix(core): correctly clear template HMR internal renderer cache #58724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal renderer cache within the renderer factory was not being correctly cleared due to a type-casting error. This prevented template HMR from correctly updating the component. A more explicity cast has now been used to mitigate this problem. Component template HMR is currently considered experimental.
crisbeto
approved these changes
Nov 18, 2024
AndrewKushnir
approved these changes
Nov 18, 2024
Contributor
|
This PR was merged into the repository by commit d33af5c. The changes were merged into the following branches: main, 19.0.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 19, 2024
The internal renderer cache within the renderer factory was not being correctly cleared due to a type-casting error. This prevented template HMR from correctly updating the component. A more explicity cast has now been used to mitigate this problem. Component template HMR is currently considered experimental. PR Close #58724
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal renderer cache within the renderer factory was not being correctly cleared due to a type-casting error. This prevented template HMR from correctly updating the component. A more explicitly cast has now been used to mitigate this problem.
Component template HMR is currently considered experimental.