Skip to content

docs(docs-infra): update default generic values and add constraints for type parameters in functions #58548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alan-agius4 wants to merge 2 commits into from
Closed

docs(docs-infra): update default generic values and add constraints for type parameters in functions #58548

alan-agius4 wants to merge 2 commits into from

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Nov 7, 2024

Before

createNodeRequestHandler(
  handler: T
): T;
class NgIf<T> {
  @Input() set ngIf(value: T);
  @Input() set ngIfThen(value: TemplateRef<NgIfContext<T>> | null);
  @Input() set ngIfElse(value: TemplateRef<NgIfContext<T>> | null);
  static ngTemplateGuard_ngIf: "binding";
  static ngTemplateContextGuard<T>(dir: NgIf<T>, ctx: any): boolean;
}

Now

createNodeRequestHandler<T extends NodeRequestHandlerFunction>(
  handler: T
): T;
class NgIf<T = unknown> {
  @Input() set ngIf(value: T);
  @Input() set ngIfThen(value: TemplateRef<NgIfContext<T>> | null);
  @Input() set ngIfElse(value: TemplateRef<NgIfContext<T>> | null);
  static ngTemplateGuard_ngIf: "binding";
  static ngTemplateContextGuard<T>(dir: NgIf<T>, ctx: any): boolean;
}

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 7, 2024
@pullapprove pullapprove bot requested a review from devversion November 7, 2024 17:18
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 7, 2024
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Nov 7, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 7, 2024
@alan-agius4 alan-agius4 force-pushed the docs-genererics branch 3 times, most recently from b99434b to 3daf209 Compare November 7, 2024 17:27
@alan-agius4
docs(docs-infra): update default generic values and add constraints f…
086cece 
…or type parameters in functions

Before
```typescript
createNodeRequestHandler(
  handler: T
): T;
```

```typescript
class NgIf<T> {
  @input() set ngIf(value: T);
  @input() set ngIfThen(value: TemplateRef<NgIfContext<T>> | null);
  @input() set ngIfElse(value: TemplateRef<NgIfContext<T>> | null);
  static ngTemplateGuard_ngIf: "binding";
  static ngTemplateContextGuard<T>(dir: NgIf<T>, ctx: any): boolean;
}
```

Now
```typescript
createNodeRequestHandler<T extends NodeRequestHandlerFunction>(
  handler: T
): T;
```

```typescript
class NgIf<T = unknown> {
  @input() set ngIf(value: T);
  @input() set ngIfThen(value: TemplateRef<NgIfContext<T>> | null);
  @input() set ngIfElse(value: TemplateRef<NgIfContext<T>> | null);
  static ngTemplateGuard_ngIf: "binding";
  static ngTemplateContextGuard<T>(dir: NgIf<T>, ctx: any): boolean;
}
```
@alan-agius4
fix(compiler-cli): correct extraction of generics from type aliases
bb7da6a 
**Before:**
```ts
type HttpEvent = | HttpSentEvent
  | HttpHeaderResponse
  | HttpResponse<T>
  | HttpProgressEvent
  | HttpUserEvent<T>
```

**After:**
```ts
type HttpEvent<T> = | HttpSentEvent
  | HttpHeaderResponse
  | HttpResponse<T>
  | HttpProgressEvent
  | HttpUserEvent<T>
```
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 8, 2024
thePunderWoman pushed a commit that referenced this pull request Nov 8, 2024
@alan-agius4 @thePunderWoman
fix(compiler-cli): correct extraction of generics from type aliases (#…
d271c44 
…58548)

**Before:**
```ts
type HttpEvent = | HttpSentEvent
  | HttpHeaderResponse
  | HttpResponse<T>
  | HttpProgressEvent
  | HttpUserEvent<T>
```

**After:**
```ts
type HttpEvent<T> = | HttpSentEvent
  | HttpHeaderResponse
  | HttpResponse<T>
  | HttpProgressEvent
  | HttpUserEvent<T>
```

PR Close #58548
thePunderWoman pushed a commit that referenced this pull request Nov 8, 2024
@alan-agius4 @thePunderWoman
docs(docs-infra): update default generic values and add constraints f…
4bebc9d 
…or type parameters in functions (#58548)

Before
```typescript
createNodeRequestHandler(
  handler: T
): T;
```

```typescript
class NgIf<T> {
  @input() set ngIf(value: T);
  @input() set ngIfThen(value: TemplateRef<NgIfContext<T>> | null);
  @input() set ngIfElse(value: TemplateRef<NgIfContext<T>> | null);
  static ngTemplateGuard_ngIf: "binding";
  static ngTemplateContextGuard<T>(dir: NgIf<T>, ctx: any): boolean;
}
```

Now
```typescript
createNodeRequestHandler<T extends NodeRequestHandlerFunction>(
  handler: T
): T;
```

```typescript
class NgIf<T = unknown> {
  @input() set ngIf(value: T);
  @input() set ngIfThen(value: TemplateRef<NgIfContext<T>> | null);
  @input() set ngIfElse(value: TemplateRef<NgIfContext<T>> | null);
  static ngTemplateGuard_ngIf: "binding";
  static ngTemplateContextGuard<T>(dir: NgIf<T>, ctx: any): boolean;
}
```

PR Close #58548
thePunderWoman pushed a commit that referenced this pull request Nov 8, 2024
@alan-agius4 @thePunderWoman
fix(compiler-cli): correct extraction of generics from type aliases (#…
791ee32 
…58548)

**Before:**
```ts
type HttpEvent = | HttpSentEvent
  | HttpHeaderResponse
  | HttpResponse<T>
  | HttpProgressEvent
  | HttpUserEvent<T>
```

**After:**
```ts
type HttpEvent<T> = | HttpSentEvent
  | HttpHeaderResponse
  | HttpResponse<T>
  | HttpProgressEvent
  | HttpUserEvent<T>
```

PR Close #58548
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Nov 8, 2024

This PR was merged into the repository by commit d271c44.

The changes were merged into the following branches: main, 18.2.x, 19.0.x

thePunderWoman pushed a commit that referenced this pull request Nov 8, 2024
@alan-agius4 @thePunderWoman
docs(docs-infra): update default generic values and add constraints f…
9199dd9 
…or type parameters in functions (#58548)

Before
```typescript
createNodeRequestHandler(
  handler: T
): T;
```

```typescript
class NgIf<T> {
  @input() set ngIf(value: T);
  @input() set ngIfThen(value: TemplateRef<NgIfContext<T>> | null);
  @input() set ngIfElse(value: TemplateRef<NgIfContext<T>> | null);
  static ngTemplateGuard_ngIf: "binding";
  static ngTemplateContextGuard<T>(dir: NgIf<T>, ctx: any): boolean;
}
```

Now
```typescript
createNodeRequestHandler<T extends NodeRequestHandlerFunction>(
  handler: T
): T;
```

```typescript
class NgIf<T = unknown> {
  @input() set ngIf(value: T);
  @input() set ngIfThen(value: TemplateRef<NgIfContext<T>> | null);
  @input() set ngIfElse(value: TemplateRef<NgIfContext<T>> | null);
  static ngTemplateGuard_ngIf: "binding";
  static ngTemplateContextGuard<T>(dir: NgIf<T>, ctx: any): boolean;
}
```

PR Close #58548
thePunderWoman pushed a commit that referenced this pull request Nov 8, 2024
@alan-agius4 @thePunderWoman
fix(compiler-cli): correct extraction of generics from type aliases (#…
4c38160 
…58548)

**Before:**
```ts
type HttpEvent = | HttpSentEvent
  | HttpHeaderResponse
  | HttpResponse<T>
  | HttpProgressEvent
  | HttpUserEvent<T>
```

**After:**
```ts
type HttpEvent<T> = | HttpSentEvent
  | HttpHeaderResponse
  | HttpResponse<T>
  | HttpProgressEvent
  | HttpUserEvent<T>
```

PR Close #58548
@alan-agius4 alan-agius4 deleted the docs-genererics branch November 8, 2024 17:27
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 9, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@alan-agius4 @thePunderWoman @devversion