fix(compiler-cli): make the unused imports diagnostic easier to read #58468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unused imports diagnostic reports once on the entire initializer and then again once per unused imports. This ends up being a bit hard to follow, because in a lot of cases the code snippet looks identical. These changes switch to highlighting the `imports:` part of the property declaration and only highlighting the unused imports without a message.
Since the unused imports diagnostic setup has changed, we need to update the code fix to account for it.
clydin
approved these changes
Nov 1, 2024
JoostK
approved these changes
Nov 1, 2024
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 1, 2024
…58468) The unused imports diagnostic reports once on the entire initializer and then again once per unused imports. This ends up being a bit hard to follow, because in a lot of cases the code snippet looks identical. These changes switch to highlighting the `imports:` part of the property declaration and only highlighting the unused imports without a message. PR Close #58468
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 1, 2024
Since the unused imports diagnostic setup has changed, we need to update the code fix to account for it. PR Close #58468
Contributor
|
This PR was merged into the repository by commit 3061c67. The changes were merged into the following branches: main, 19.0.x |
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 1, 2024
Since the unused imports diagnostic setup has changed, we need to update the code fix to account for it. PR Close #58468
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unused imports diagnostic reports once on the entire initializer and then again once per unused imports. This ends up being a bit hard to follow, because in a lot of cases the code snippet looks identical.
These changes switch to highlighting the
imports:part of the property declaration and only highlighting the unused imports without a message.For reference, this is what the diagnostic looks like at the moment:
And here's what it looks like after the changes:
