fix(migrations): properly replace imports across files#58414
fix(migrations): properly replace imports across files#58414pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Conversation
This change fixes a bug where the output migration was interacting with the InputManager utility in the way that was resulting in incorrect import replacements. The fix consists of making sure that a new ImportManager instance is created for each and every file containing @output declarations.
|
@devversion @crisbeto I might be very well misusing Open to improvement suggestions, thnx! |
|
@pkozlowski-opensource with the approach we took for the output migration; this PR makes a lot of sense to me. In the future, we still have the TODO/AI to investigate how we can improve the import manager for Tsurge funnel migrations |
crisbeto
left a comment
There was a problem hiding this comment.
Yeah, I don't see a reason why we should be sharing the instance across files.
|
This PR was merged into the repository by commit db7ed20. The changes were merged into the following branches: main, 19.0.x |
This change fixes a bug where the output migration was interacting with the InputManager utility in the way that was resulting in incorrect import replacements. The fix consists of making sure that a new ImportManager instance is created for each and every file containing @output declarations. PR Close #58414
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This change fixes a bug where the output migration was interacting with the InputManager utility in the way that was resulting in incorrect import replacements.
The fix consists of making sure that a new ImportManager instance is created for each and every file containing @output declarations.