fix(core): Prevents trying to trigger incremental hydration on CSR #58366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33389d0 to
1349acf
Compare
462618d to
81be4a3
Compare
Contributor
There was a problem hiding this comment.
I'd propose adding a TODO here to refactor the code (resolving circular deps if needed), so that we don't have to have this callback function (it should probably be inside of the incrementallyHydrateFromBlockName one).
Contributor
Author
There was a problem hiding this comment.
The initial circular dep problem is actually why this function is here at all. It was initially in the proposed location and wasn't resolvable without extracting this into a function like this. These are the cleanup fns. I can add a TODO though.
81be4a3 to
95d316e
Compare
95d316e to
35d420f
Compare
35d420f to
42858d0
Compare
AndrewKushnir
approved these changes
Oct 28, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGTM with a minor comment.
hydrate triggers were firing in CSR cases and attempting to find parent defer blocks. This prevents that from happening. In these cases, the defer block id will be empty. fixes: angular#58359
This adds a shouldHydrate check that prevents any additional work in cases when hydration is not necessary.
42858d0 to
2608df9
Compare
Member
|
This PR was merged into the repository by commit 2e11b6f. The changes were merged into the following branches: main, 19.0.x |
alxhub
pushed a commit
that referenced
this pull request
Oct 29, 2024
alxhub
pushed a commit
that referenced
this pull request
Oct 29, 2024
This adds a shouldHydrate check that prevents any additional work in cases when hydration is not necessary. PR Close #58366
alxhub
pushed a commit
that referenced
this pull request
Oct 29, 2024
This adds a shouldHydrate check that prevents any additional work in cases when hydration is not necessary. PR Close #58366
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hydrate triggers were firing in CSR cases and attempting to find parent defer blocks. This prevents that from happening. In these cases, the defer block id will be empty.
fixes: #58359
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #58359
Does this PR introduce a breaking change?