Skip to content

fix(router): remove setter for injector on OutletContext #58343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
josephperrott wants to merge 1 commit into from
Closed

fix(router): remove setter for injector on OutletContext #58343

josephperrott wants to merge 1 commit into from

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Oct 24, 2024

This is a cleanup/completion of the work in #56798

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels Oct 24, 2024
@josephperrott josephperrott requested a review from atscott October 24, 2024 14:16
@josephperrott josephperrott changed the title fix(router): remove setter for \injector\ on OutletContext fix(router): remove setter for injector on OutletContext Oct 24, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 24, 2024
@josephperrott josephperrott marked this pull request as ready for review October 24, 2024 14:45
@pullapprove pullapprove bot removed the request for review from atscott October 24, 2024 14:45
@josephperrott josephperrott requested a review from atscott October 24, 2024 14:45
AndrewKushnir
AndrewKushnir approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

thePunderWoman
thePunderWoman approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@alxhub
Copy link
Member

alxhub commented Oct 24, 2024

This PR was merged into the repository by commit bad3651.

The changes were merged into the following branches: main, 19.0.x

@alxhub alxhub closed this in bad3651 Oct 24, 2024
alxhub pushed a commit that referenced this pull request Oct 24, 2024
@josephperrott @alxhub
fix(router): remove setter for injector on OutletContext (#58343)
a49c35e 
This is a cleanup/completion of the work in #56798

PR Close #58343
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 24, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: router target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@josephperrott @alxhub @atscott @thePunderWoman @AndrewKushnir